STORM-3242: Adds "examples" and "externals" profiles #2858
Conversation
|
Agree. If there are errors/failures in travis-ci, then I will take a look. |
There was a problem hiding this comment.
👍 LGTM. This would help a lot during testing. Thank you @d2r
|
This looks good, but I'm wondering if Flux and the sql modules should be added to externals as well? They depend on storm-kafka-client, so the build won't work with externals disabled unless you happen to already have storm-kafka-client in your local repo. |
|
Sorry @srdo is right we need to make sure that we have the dependencies setup properly. |
|
Yes, thank you @srdo for pointing this out. Would it be all right merely to move |
|
I'd be fine with just moving them to the new profile. It already contains the integration test, which also isn't in externals. |
|
OK this is done. rm -rf ~/.m2/repository/
mvn clean install -DskipTests=true -U -P '!examples,!externals' |
|
+1, thanks for addressing my comment. Please squash to one commit containing the issue number. |
The existing modules have been moved into like-named Maven profiles that are enabled by default. Updates travis-ci script to use new profiles https://maven.apache.org/guides/introduction/introduction-to-profiles.html > All profiles that are active by default are automatically deactivated > when a profile in the POM is activated on the command line or through > its activation config. Therefore we should activate the new profiles whenever we explicitly activate another profile. Moves sql and flux to externals profile
d2r
force-pushed
the
storm-3242-examples-externals-maven-profiles
branch
from
9aeac5e
to
a9ff440
Compare
|
Squashed; old commit was 9aeac5e. |
|
Thanks @d2r, merged to master. |
The existing modules have been moved into like-named Maven profiles that
are enabled by default.
They can be disabled, for example, with: