Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STORM-3565] add support for adding dimensions to metric data points #3194

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

RuiLi8080
Copy link
Contributor

A dimensional metric collects information into multiple sub-categories (dimensions).
Add an interface IDimensionalMetric extending IMetric in hope for supporting a better fine-grained metric reporting.
DimensionalCountMetric serves as an example for creating and using dimensional metric

@kishorvpatil
Copy link
Contributor

Having DimensionalCountMetric is excluding all other IMetric implementations that would required Dimensional implementation.

@RuiLi8080 RuiLi8080 force-pushed the STORM-3565 branch 2 times, most recently from 1c54004 to c9d63a3 Compare January 30, 2020 15:59
@RuiLi8080
Copy link
Contributor Author

Re-worked on this PR. My thinking is to add a dimensions field in IMetricConsumer.DataPoint as an additional K-V metadata map. Data points are collected from metric measurement. The optional additional information could be helpful when downstream monitoring system want to organize or group those datapoints.

@rzo1 rzo1 merged commit 0eb7212 into apache:master Dec 4, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants