[STORM-3271] enable supervisors to launch a worker inside a docker container #3287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ethanlm
force-pushed
the
STORM-3271-docker
branch
2 times, most recently
from
a8b9127
to
1841f58
Compare
Ethanlm
force-pushed
the
STORM-3271-docker
branch
from
1841f58
to
f70036f
Compare
kishorvpatil
reviewed
Jul 2, 2020
| * @return the full command. | ||
| */ | ||
| @Override | ||
| public String getCommandWithArguments() { |
There was a problem hiding this comment.
Do we need to override this method? Looks like the parent DockerCommand.getCommandWithArguments is doing the same thing.
There was a problem hiding this comment.
You are right. I will remove this one.
agresch
reviewed
Jul 7, 2020
storm-server/src/main/java/org/apache/storm/utils/ServerUtils.java
Outdated
Show resolved
Hide resolved
agresch
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
With this new functionality, a supervisor can launch a worker process inside a docker container for better security and portability.
How was the change tested