STORM-3749 improve logging for server error #3384
Conversation
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void exceptionCaught(ChannelHandlerContext ctx, Throwable cause) { | ||
| try { | ||
| LOG.error("server errors in handling the request", cause); | ||
| LOG.error("server errors in handling the request to " + ctx.channel().remoteAddress().toString(), cause); |
There was a problem hiding this comment.
change "to" to "from" since this is an ChannelInboundHandlerAdapter?
nit: Use "{}" instead of "+". i.e.
LOG.error("server errors in handling the request from {}", ctx.channel().remoteAddress().toString(), cause);
There was a problem hiding this comment.
Actually, I found (earlier) that passing parameter in the LOG.error does not handle the exception properly (i.e. stack trace is not printed). This maybe because we use an older version of SL4J. So the error above with {} will print only the message text but not stack. But if there is only one argument then the stack trace is printed. Here is a link that refers to sl4j version where this was fixed http://www.slf4j.org/faq.html#paramException
There was a problem hiding this comment.
Ignore previous comment. I just tested this in a storm test and parameters work in LOG.error correctly as expected.
agresch
force-pushed
the
agresch_storm_3749
branch
from
8f20a13
to
4b8d589
Compare
What is the purpose of the change
Improve the error message when a server error occurs/
How was the change tested
built storm-client