STORM-3781 switch recv-iconnection to v2 metric api #3402
Conversation
| for (Map.Entry<String, AtomicLong> ent : byteCounts.entrySet()) { | ||
| AtomicLong count = ent.getValue(); | ||
| if (count.get() > 0) { | ||
| counts.put(ent.getKey(), count.getAndSet(0L)); |
There was a problem hiding this comment.
Looks like this won't support multiple reporters?
In the case of multiple reporters being configured, this getAndSet will return differently
There was a problem hiding this comment.
I don't see a good way to support that with the V2 interface. Possibly we could provide hooks to allow the metrics to know what reporters exist and when they report. Then they could defer resetting until all reporters have reported. But even then there could be frequency differences between multiple reporters.
We could leave these as V1 metrics if that is preferred. I am not sure how often these are used.
| if (metricRegistry != null) { | ||
| Gauge<Map<String, Integer>> enqueued = new Gauge<Map<String, Integer>>() { | ||
| @Override | ||
| public Map<String, Integer> getValue() { |
There was a problem hiding this comment.
Does it support having multiple reporters?
|
I am a newcomer to Storm, I have a question to ask, how did STORM-3781 come from? |
|
The recv-iconnection metrics are using a deprecated (v1) metrics API. This JIRA is to update them to the newer v2 API. |
|
closing for now |
What is the purpose of the change
Updates metrics to V2 API.
How was the change tested
Ran storm-client unit tests. Validated metrics log for word count topology.