[STORM-3902] Print summary of differences between expected and actual licenses #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DEPENDENCY-LICENSES files.
rzo1
approved these changes
Mar 23, 2023
agresch
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in DEPENDENCY-LICENSES
What is the purpose of the change
Usual update to the build process occurs in small increments, and therefore the license differences are usually small to none. If just the summary of differences is printed then it is faster to spot and correct the differences and speeds up the iteration - as apposed to downloading the two files and doing a local diff.
How was the change tested
Running the script locally. Also this script automatically gets executed for every pull request