[STORM-3895] Add JDK-17 build #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very good initiative, thanks ! |
agresch
approved these changes
Jul 27, 2023
…er - to allow reflection on java.base
agresch
reviewed
Jul 27, 2023
| @@ -169,6 +169,8 @@ | |||
| <artifactId>maven-surefire-plugin</artifactId> | |||
| <configuration> | |||
| <forkCount>1</forkCount> | |||
| <!-- remove this when ServerUtilsTest.getPidOfPosixProcess() returns p.pid() as allowed in JDK11 and above --> | |||
There was a problem hiding this comment.
I'm not sure what this issue is, but I would file a JIRA for it and mention it in this comment so we can track progress.
… test under JDK17
|
For some reason, under openjdk-17, the license file is much smaller (and different) from that generated under jdk8 and jdk11. Wondering is this is related to strict isolation of packages and restrictions on reflection introduced in JDK17. |
… specific overrides based on JDK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add JDK-17 Build
How was the change tested
Let the github actions run