STORM-1016: Generate trident bolt ids with sorted group names #706
Conversation
|
@Victor-Wong these changes look good, but would it be cleaner to just use a TreeMap instead of a HashMap? |
|
@Victor-Wong any update on this? |
|
@revans2 sorry for replying so late, I just made some changes and it worked OK. Is that what you mean? |
|
@Victor-Wong yes that is exactly what I was thinking, makes the code a lot smaller. I am +1 on this change, but it looks like there is a code conflict. Could you upmerge your changes? And don't worry about it taking a while. |
Conflicts: storm-core/src/jvm/storm/trident/TridentTopology.java storm-core/src/jvm/storm/trident/graph/GraphGrouper.java
|
@revans2 changes upmerged. Is that right? |
|
The build is complaining that storm-core/test/jvm/storm/trident/TestTridentTopology.java does not have an apache license header. |
| @@ -34,8 +31,8 @@ | |||
|
|
|||
| public GraphGrouper(DirectedGraph<Node, IndexedEdge> graph, Collection<Group> initialGroups) { | |||
| this.graph = graph; | |||
| this.currGroups = new HashSet<>(initialGroups); | |||
| reindex(); | |||
| this.currGroups = new LinkedHashSet(initialGroups); | |||
There was a problem hiding this comment.
Could you put the <> characters back at the end of the LinkedHashSet?
|
Two very minor things, and I am +1 |
|
done :) |
|
+1 |
PR for STORM-1016