Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ObjectDef.java for flux #732

Merged
merged 1 commit into from Nov 24, 2015
Merged

Update ObjectDef.java for flux #732

merged 1 commit into from Nov 24, 2015

Conversation

lispking
Copy link
Contributor

update:let constructorArgs support map type.

update:let constructorArgs support map type.
@lispking lispking changed the title Update ObjectDef.java Update ObjectDef.java for flux Sep 14, 2015
@revans2
Copy link
Contributor

revans2 commented Nov 6, 2015

@lispking is there a JIRA for this? The change looks good to me and I am +1 for merging it in.

@ptgoetz could you also take a look?

@ptgoetz
Copy link
Member

ptgoetz commented Nov 6, 2015

I'd like to see this change covered by the unit tests. It should be as simple as adding a constructor, config method, etc. that takes a map as input to one of the dummy classes, then reference it in one of the unit test YAML files.

@ptgoetz
Copy link
Member

ptgoetz commented Nov 24, 2015

+1 tests can be added later

@asfgit asfgit merged commit a019d50 into apache:master Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants