This repository has been archived by the owner on May 12, 2021. It is now read-only.
Messaging model changes and MQTT integration #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
September 22, 2014 14:28
|
I solved merge conflicts and integrated this PR. Thanks Gayan. However, later found that this PR has introduced a regression https://issues.apache.org/jira/browse/STRATOS-820 Gayan, could you please send another PR to solve this regression issue? |
|
This is already merged and add the new pull request (#58) for STRATOS-820. Hence closed the PR |
| } catch (RegistryException e) { | ||
| String msg = "Failed when retrieving Governance System Registry."; | ||
| log.error(msg, e); | ||
| throw new CloudControllerException(msg, e); |
There was a problem hiding this comment.
Thanks Johann.
Yeah it will create multiple logs.Code base use the log and throw pattern as it contains information which will not get logged further up the call stack.
|
Thanks Johann for point out this. Added the PR#159 with the context aware error messages. |
|
Thanks Johann for the comments. Added the PR#159 with the context aware error messages. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following:
1.Messaging model changes and MQTT updates
2.Puppet master update with python agent