Skip to content

Commit

Permalink
Rename AdapterInterface to StreamPipesAdapter (#1590)
Browse files Browse the repository at this point in the history
  • Loading branch information
dominikriemer committed May 25, 2023
1 parent eec594f commit 92b6943
Show file tree
Hide file tree
Showing 36 changed files with 88 additions and 88 deletions.
Expand Up @@ -28,7 +28,7 @@ public interface IAdapterConfiguration {

AdapterDescription getAdapterDescription();

Supplier<AdapterInterface> getSupplier();
Supplier<StreamPipesAdapter> getSupplier();

void setAdapterDescription(AdapterDescription adapterDescription);
}
Expand Up @@ -25,7 +25,7 @@
import org.apache.streampipes.model.connect.guess.GuessSchema;

// TODO Rename to IAdapter once the old class can be deleted
public interface AdapterInterface {
public interface StreamPipesAdapter {
IAdapterConfiguration declareConfig();

void onAdapterStarted(IAdapterParameterExtractor extractor,
Expand Down
Expand Up @@ -19,7 +19,7 @@
package org.apache.streampipes.extensions.management.connect;

import org.apache.streampipes.commons.exceptions.connect.AdapterException;
import org.apache.streampipes.extensions.api.connect.AdapterInterface;
import org.apache.streampipes.extensions.api.connect.StreamPipesAdapter;
import org.apache.streampipes.extensions.api.connect.context.IAdapterRuntimeContext;
import org.apache.streampipes.extensions.api.monitoring.SpMonitoringManager;
import org.apache.streampipes.extensions.management.connect.adapter.model.EventCollector;
Expand Down Expand Up @@ -82,7 +82,7 @@ public void stopAdapter(AdapterDescription adapterDescription) throws AdapterExc

String elementId = adapterDescription.getElementId();

AdapterInterface adapter = RunningAdapterInstances.INSTANCE.removeAdapter(elementId);
StreamPipesAdapter adapter = RunningAdapterInstances.INSTANCE.removeAdapter(elementId);

if (adapter != null) {

Expand Down
Expand Up @@ -17,7 +17,7 @@
*/
package org.apache.streampipes.extensions.management.connect;

import org.apache.streampipes.extensions.api.connect.AdapterInterface;
import org.apache.streampipes.extensions.api.connect.StreamPipesAdapter;
import org.apache.streampipes.extensions.management.init.DeclarersSingleton;
import org.apache.streampipes.extensions.management.locales.LabelGenerator;
import org.apache.streampipes.model.connect.adapter.AdapterDescription;
Expand Down Expand Up @@ -57,7 +57,7 @@ public Optional<AdapterDescription> getAdapterDescription(String id) {
* This is a helper method to mock the Declarer Singleton in unit tests
* @return the registered adapters from the DeclarerSingleton
*/
public Collection<AdapterInterface> getRegisteredAdapters() {
public Collection<StreamPipesAdapter> getRegisteredAdapters() {
return DeclarersSingleton.getInstance().getAdapters();
}

Expand Down
Expand Up @@ -18,17 +18,17 @@

package org.apache.streampipes.extensions.management.connect;

import org.apache.streampipes.extensions.api.connect.AdapterInterface;
import org.apache.streampipes.extensions.api.connect.StreamPipesAdapter;
import org.apache.streampipes.extensions.management.init.DeclarersSingleton;

import java.util.Map;

public class RuntimeResovable {
private static final String SP_NS = "https://streampipes.org/vocabulary/v1/";

public static AdapterInterface getAdapter(String id) {
public static StreamPipesAdapter getAdapter(String id) {
id = id.replaceAll("sp:", SP_NS);
Map<String, AdapterInterface> allAdapters = DeclarersSingleton.getInstance().getAdapterMap();
Map<String, StreamPipesAdapter> allAdapters = DeclarersSingleton.getInstance().getAdapterMap();

if (allAdapters.containsKey(id)) {
return allAdapters.get(id);
Expand Down
Expand Up @@ -20,7 +20,7 @@

import org.apache.streampipes.dataformat.SpDataFormatFactory;
import org.apache.streampipes.dataformat.SpDataFormatManager;
import org.apache.streampipes.extensions.api.connect.AdapterInterface;
import org.apache.streampipes.extensions.api.connect.StreamPipesAdapter;
import org.apache.streampipes.extensions.api.declarer.DataStreamDeclarer;
import org.apache.streampipes.extensions.api.declarer.Declarer;
import org.apache.streampipes.extensions.api.declarer.IStreamPipesFunctionDeclarer;
Expand Down Expand Up @@ -66,7 +66,7 @@ public class DeclarersSingleton implements IDeclarersSingleton {
private Map<String, TransportProtocol> supportedProtocols;
private Map<String, TransportFormat> supportedFormats;

private Map<String, AdapterInterface> adapters;
private Map<String, StreamPipesAdapter> adapters;

private String serviceId;

Expand Down Expand Up @@ -253,19 +253,19 @@ public Map<String, IStreamPipesFunctionDeclarer> getFunctions() {
return functions;
}

public Collection<AdapterInterface> getAdapters() {
public Collection<StreamPipesAdapter> getAdapters() {
return adapters.values();
}

public Map<String, AdapterInterface> getAdapterMap() {
public Map<String, StreamPipesAdapter> getAdapterMap() {
return adapters;
}

public void setAdapters(List<AdapterInterface> adapters) {
public void setAdapters(List<StreamPipesAdapter> adapters) {
adapters.forEach(a -> this.adapters.put(a.declareConfig().getAdapterDescription().getAppId(), a));
}

public Optional<AdapterInterface> getAdapter(String id) {
public Optional<StreamPipesAdapter> getAdapter(String id) {
return getAdapters().stream()
.filter(adapter -> adapter.declareConfig()
.getAdapterDescription()
Expand Down
Expand Up @@ -18,10 +18,10 @@

package org.apache.streampipes.extensions.management.init;

import org.apache.streampipes.extensions.api.connect.AdapterInterface;
import org.apache.streampipes.extensions.api.connect.StreamPipesAdapter;

import java.util.Optional;

public interface IDeclarersSingleton {
Optional<AdapterInterface> getAdapter(String id);
Optional<StreamPipesAdapter> getAdapter(String id);
}
Expand Up @@ -18,7 +18,7 @@

package org.apache.streampipes.extensions.management.init;

import org.apache.streampipes.extensions.api.connect.AdapterInterface;
import org.apache.streampipes.extensions.api.connect.StreamPipesAdapter;
import org.apache.streampipes.model.connect.adapter.AdapterDescription;

import java.util.Collection;
Expand All @@ -28,16 +28,16 @@
public enum RunningAdapterInstances {
INSTANCE;

private final Map<String, AdapterInterface> runningAdapterInstances = new HashMap<>();
private final Map<String, StreamPipesAdapter> runningAdapterInstances = new HashMap<>();
private final Map<String, AdapterDescription> runningAdapterDescriptionInstances = new HashMap<>();

public void addAdapter(String elementId, AdapterInterface adapter, AdapterDescription adapterDescription) {
public void addAdapter(String elementId, StreamPipesAdapter adapter, AdapterDescription adapterDescription) {
runningAdapterInstances.put(elementId, adapter);
runningAdapterDescriptionInstances.put(elementId, adapterDescription);
}

public AdapterInterface removeAdapter(String elementId) {
AdapterInterface result = runningAdapterInstances.get(elementId);
public StreamPipesAdapter removeAdapter(String elementId) {
StreamPipesAdapter result = runningAdapterInstances.get(elementId);
runningAdapterInstances.remove(elementId);
runningAdapterDescriptionInstances.remove(elementId);
return result;
Expand Down
Expand Up @@ -18,7 +18,7 @@
package org.apache.streampipes.extensions.management.model;

import org.apache.streampipes.dataformat.SpDataFormatFactory;
import org.apache.streampipes.extensions.api.connect.AdapterInterface;
import org.apache.streampipes.extensions.api.connect.StreamPipesAdapter;
import org.apache.streampipes.extensions.api.declarer.Declarer;
import org.apache.streampipes.extensions.api.declarer.IStreamPipesFunctionDeclarer;
import org.apache.streampipes.messaging.SpProtocolDefinitionFactory;
Expand All @@ -43,7 +43,7 @@ public class SpServiceDefinition {
private List<SpProtocolDefinitionFactory<?>> protocolDefinitionFactories;
private List<IStreamPipesFunctionDeclarer> functions;

private List<AdapterInterface> adapters;
private List<StreamPipesAdapter> adapters;

private Map<String, ConfigItem> kvConfigs;

Expand Down Expand Up @@ -125,11 +125,11 @@ public void addConfig(ConfigItem configItem) {
this.kvConfigs.put(configItem.getKey(), configItem);
}

public void addAdapter(AdapterInterface adapter) {
public void addAdapter(StreamPipesAdapter adapter) {
this.adapters.add(adapter);
}

public void addAdapters(List<AdapterInterface> adapters) {
public void addAdapters(List<StreamPipesAdapter> adapters) {
this.adapters.addAll(adapters);
}

Expand Down Expand Up @@ -169,7 +169,7 @@ public List<IStreamPipesFunctionDeclarer> getFunctions() {
return functions;
}

public List<AdapterInterface> getAdapters() {
public List<StreamPipesAdapter> getAdapters() {
return adapters;
}
}
Expand Up @@ -18,7 +18,7 @@
package org.apache.streampipes.extensions.management.model;

import org.apache.streampipes.dataformat.SpDataFormatFactory;
import org.apache.streampipes.extensions.api.connect.AdapterInterface;
import org.apache.streampipes.extensions.api.connect.StreamPipesAdapter;
import org.apache.streampipes.extensions.api.declarer.Declarer;
import org.apache.streampipes.extensions.api.declarer.IStreamPipesFunctionDeclarer;
import org.apache.streampipes.messaging.SpProtocolDefinitionFactory;
Expand Down Expand Up @@ -96,7 +96,7 @@ public SpServiceDefinitionBuilder registerPipelineElements(Declarer<?>... declar
return this;
}

public SpServiceDefinitionBuilder registerAdapter(AdapterInterface adapter) {
public SpServiceDefinitionBuilder registerAdapter(StreamPipesAdapter adapter) {
this.serviceDefinition.addAdapter(adapter);
return this;
}
Expand Down
Expand Up @@ -17,7 +17,7 @@
*/
package org.apache.streampipes.extensions.management.util;

import org.apache.streampipes.extensions.api.connect.AdapterInterface;
import org.apache.streampipes.extensions.api.connect.StreamPipesAdapter;
import org.apache.streampipes.extensions.api.declarer.Declarer;
import org.apache.streampipes.model.SpDataStream;
import org.apache.streampipes.model.base.NamedStreamPipesEntity;
Expand Down Expand Up @@ -51,7 +51,7 @@ private static SpServiceTagPrefix getPrefix(NamedStreamPipesEntity entity) {
}
}

public static List<SpServiceTag> extractAppIdsFromAdapters(Collection<AdapterInterface> adapters) {
public static List<SpServiceTag> extractAppIdsFromAdapters(Collection<StreamPipesAdapter> adapters) {
return adapters
.stream()
.map(d -> SpServiceTag.create(
Expand Down
Expand Up @@ -18,7 +18,7 @@

package org.apache.streampipes.extensions.management.connect;

import org.apache.streampipes.extensions.api.connect.AdapterInterface;
import org.apache.streampipes.extensions.api.connect.StreamPipesAdapter;
import org.apache.streampipes.sdk.builder.adapter.AdapterConfigurationBuilder;

import org.junit.Before;
Expand All @@ -42,15 +42,15 @@ public class ConnectWorkerDescriptionProviderTest {
public void initializeProvider() {
provider = spy(new ConnectWorkerDescriptionProvider());

var testAdapter = mock(AdapterInterface.class);
var testAdapter = mock(StreamPipesAdapter.class);
doAnswer(invocation ->
AdapterConfigurationBuilder
.create(adapterId, null)
.buildConfiguration())
.when(testAdapter)
.declareConfig();

List<AdapterInterface> adapters = List.of(testAdapter);
List<StreamPipesAdapter> adapters = List.of(testAdapter);
doReturn(adapters).when(provider).getRegisteredAdapters();
}

Expand Down
Expand Up @@ -18,7 +18,7 @@

package org.apache.streampipes.extensions.management.init;

import org.apache.streampipes.extensions.api.connect.AdapterInterface;
import org.apache.streampipes.extensions.api.connect.StreamPipesAdapter;
import org.apache.streampipes.sdk.builder.adapter.AdapterConfigurationBuilder;

import org.junit.Test;
Expand All @@ -35,7 +35,7 @@ public class DeclarersSingletonTest {
@Test
public void getAdapterTest() {
var id = "id";
var testAdapter = mock(AdapterInterface.class);
var testAdapter = mock(StreamPipesAdapter.class);
doAnswer(invocation ->
AdapterConfigurationBuilder
.create(id, null)
Expand Down
Expand Up @@ -18,7 +18,7 @@

package org.apache.streampipes.extensions.management.model;

import org.apache.streampipes.extensions.api.connect.AdapterInterface;
import org.apache.streampipes.extensions.api.connect.StreamPipesAdapter;
import org.apache.streampipes.extensions.api.connect.IAdapterConfiguration;
import org.apache.streampipes.extensions.api.connect.IEventCollector;
import org.apache.streampipes.extensions.api.connect.context.IAdapterGuessSchemaContext;
Expand All @@ -43,7 +43,7 @@ public void registerAdapter() {
assertEquals(expected, result.getAdapters().get(0));
}

private static class TestAdapter implements AdapterInterface {
private static class TestAdapter implements StreamPipesAdapter {

@Override
public IAdapterConfiguration declareConfig() {
Expand Down
Expand Up @@ -22,7 +22,7 @@
import org.apache.streampipes.commons.exceptions.connect.AdapterException;
import org.apache.streampipes.connect.iiot.adapters.opcua.configuration.SpOpcUaConfigBuilder;
import org.apache.streampipes.connect.iiot.adapters.opcua.utils.OpcUaUtil;
import org.apache.streampipes.extensions.api.connect.AdapterInterface;
import org.apache.streampipes.extensions.api.connect.StreamPipesAdapter;
import org.apache.streampipes.extensions.api.connect.IAdapterConfiguration;
import org.apache.streampipes.extensions.api.connect.IEventCollector;
import org.apache.streampipes.extensions.api.connect.IPullAdapter;
Expand Down Expand Up @@ -74,7 +74,7 @@
import static org.apache.streampipes.connect.iiot.adapters.opcua.utils.OpcUaUtil.OpcUaLabels.OPC_URL;
import static org.apache.streampipes.connect.iiot.adapters.opcua.utils.OpcUaUtil.getSchema;

public class OpcUaAdapter implements AdapterInterface, IPullAdapter, SupportsRuntimeConfig {
public class OpcUaAdapter implements StreamPipesAdapter, IPullAdapter, SupportsRuntimeConfig {

public static final String ID = "org.apache.streampipes.connect.iiot.adapters.opcua";
private static final Logger LOG = LoggerFactory.getLogger(OpcUaAdapter.class);
Expand Down
Expand Up @@ -20,7 +20,7 @@


import org.apache.streampipes.commons.exceptions.connect.AdapterException;
import org.apache.streampipes.extensions.api.connect.AdapterInterface;
import org.apache.streampipes.extensions.api.connect.StreamPipesAdapter;
import org.apache.streampipes.extensions.api.connect.IAdapterConfiguration;
import org.apache.streampipes.extensions.api.connect.IEventCollector;
import org.apache.streampipes.extensions.api.connect.IPullAdapter;
Expand Down Expand Up @@ -65,7 +65,7 @@
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeUnit;

public class Plc4xModbusAdapter implements AdapterInterface, IPullAdapter {
public class Plc4xModbusAdapter implements StreamPipesAdapter, IPullAdapter {

private static final Logger LOG = LoggerFactory.getLogger(Plc4xModbusAdapter.class);
/**
Expand Down
Expand Up @@ -20,7 +20,7 @@


import org.apache.streampipes.commons.exceptions.connect.AdapterException;
import org.apache.streampipes.extensions.api.connect.AdapterInterface;
import org.apache.streampipes.extensions.api.connect.StreamPipesAdapter;
import org.apache.streampipes.extensions.api.connect.IAdapterConfiguration;
import org.apache.streampipes.extensions.api.connect.IEventCollector;
import org.apache.streampipes.extensions.api.connect.IPullAdapter;
Expand Down Expand Up @@ -66,7 +66,7 @@
import java.util.concurrent.TimeUnit;
import java.util.stream.Collectors;

public class Plc4xS7Adapter implements AdapterInterface, IPullAdapter, PlcReadResponseHandler {
public class Plc4xS7Adapter implements StreamPipesAdapter, IPullAdapter, PlcReadResponseHandler {

/**
* A unique id to identify the Plc4xS7Adapter
Expand Down
Expand Up @@ -20,7 +20,7 @@


import org.apache.streampipes.commons.exceptions.connect.AdapterException;
import org.apache.streampipes.extensions.api.connect.AdapterInterface;
import org.apache.streampipes.extensions.api.connect.StreamPipesAdapter;
import org.apache.streampipes.extensions.api.connect.IAdapterConfiguration;
import org.apache.streampipes.extensions.api.connect.IEventCollector;
import org.apache.streampipes.extensions.api.connect.context.IAdapterGuessSchemaContext;
Expand Down Expand Up @@ -56,7 +56,7 @@
import java.util.concurrent.TimeUnit;
import java.util.stream.Collectors;

public class RosBridgeAdapter implements AdapterInterface, ResolvesContainerProvidedOptions {
public class RosBridgeAdapter implements StreamPipesAdapter, ResolvesContainerProvidedOptions {

public static final String ID = "org.apache.streampipes.connect.iiot.adapters.ros";

Expand Down
Expand Up @@ -19,7 +19,7 @@
package org.apache.streampipes.connect.iiot.adapters.simulator.machine;

import org.apache.streampipes.commons.exceptions.connect.AdapterException;
import org.apache.streampipes.extensions.api.connect.AdapterInterface;
import org.apache.streampipes.extensions.api.connect.StreamPipesAdapter;
import org.apache.streampipes.extensions.api.connect.IAdapterConfiguration;
import org.apache.streampipes.extensions.api.connect.IEventCollector;
import org.apache.streampipes.extensions.api.connect.context.IAdapterGuessSchemaContext;
Expand All @@ -33,7 +33,7 @@
import org.apache.streampipes.sdk.helpers.Options;
import org.apache.streampipes.sdk.utils.Assets;

public class MachineDataSimulatorAdapter implements AdapterInterface {
public class MachineDataSimulatorAdapter implements StreamPipesAdapter {

private static final String ID = "org.apache.streampipes.connect.iiot.adapters.simulator.machine";
private static final String WAIT_TIME_MS = "wait-time-ms";
Expand Down

0 comments on commit 92b6943

Please sign in to comment.