Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Event Runtime Name of geometry field #1040

Closed
Tracked by #795
flomickl opened this issue Jan 5, 2023 · 1 comment · Fixed by #1268
Closed
Tracked by #795

Change Event Runtime Name of geometry field #1040

flomickl opened this issue Jan 5, 2023 · 1 comment · Fixed by #1268
Assignees
Labels
breaking change Indicates that a PR or issue yields to a breaking change pipeline elements Relates to pipeline elements
Milestone

Comments

@flomickl
Copy link
Contributor

flomickl commented Jan 5, 2023

Currently, the runtime name of the geometry event is called geomWKT
which is not a proper name anymore.
Bedder is geometry or geom as a name.
The processors have to be changed in the output strategy.
Also some other fields needs to be added. e.g. relatet epsg fields for new geometry fields

@flomickl flomickl self-assigned this Jan 5, 2023
@bossenti bossenti added pipeline elements Relates to pipeline elements breaking change Indicates that a PR or issue yields to a breaking change labels Jan 6, 2023
@bossenti bossenti added this to the 1.0.0 milestone Jan 6, 2023
@flomickl
Copy link
Contributor Author

flomickl commented Feb 11, 2023

#1265 (comment)

What do you think about this: (before I create a special discussion)
Is it possible to create and use RUNTIME_names that are used more often, like the vocabulary list, globally somewhere?
Instead of define it in each processor class it is stored like Geo.LAT vocabulary in a separate class.

...
private static final String GEOM_RUNTIME="geometry"
private static final String TEMPERATUR_RUNTIME="temperature"
...
        .outputStrategy(
            OutputStrategies.append(
                PrimitivePropertyBuilder
                    .create(Datatypes.String, GEOM_RUNTIME)
                    .domainProperty(Geo.LAT)
                    .build()
            )
...

It is stored in a Class Runtime
and is used like

        .outputStrategy(
            OutputStrategies.append(
                PrimitivePropertyBuilder
...
 ->                   .create(Datatypes.String, RUNTIME.GEOMETRY)
...
                    .build()
            )

The advantage of this approach would be,
that the runtime name e.g. with the keep + updateField method, the correct runtime name can be selected more easily.

@flomickl flomickl linked a pull request Feb 11, 2023 that will close this issue
flomickl added a commit that referenced this issue Feb 15, 2023
flomickl added a commit that referenced this issue Feb 15, 2023
[#1040] remove supported code in declaire
flomickl added a commit that referenced this issue Feb 18, 2023
…f-geometry-field

[#1040] rework schema definitions in geo processors
flomickl added a commit that referenced this issue Feb 18, 2023
flomickl added a commit that referenced this issue Feb 18, 2023
[#1040] remove supported code in declaire
@bossenti bossenti modified the milestones: 1.0.0, 0.92.0 May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Indicates that a PR or issue yields to a breaking change pipeline elements Relates to pipeline elements
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants