Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python MkDocs use old StreamPipes logo #1088

Closed
tenthe opened this issue Jan 12, 2023 · 12 comments · Fixed by #1095
Closed

Python MkDocs use old StreamPipes logo #1088

tenthe opened this issue Jan 12, 2023 · 12 comments · Fixed by #1095
Labels
good first issue Good for newcomers python Pull requests that update Python code
Milestone

Comments

@tenthe
Copy link
Contributor

tenthe commented Jan 12, 2023

Body

Description

MkDocs still use the old StreamPipes logo (See [1]).
This should be replaced with the new logo.

Mentoring

As this ticket is marked as good first issue: @bossenti or @tenthe are happy to provide help for getting started, just tag one of them if you want to start working on this issue and need some help.
This issue might be a good issue for people who want to get started contributing to StreamPipes.

[1] https://github.com/apache/streampipes/blob/dev/streampipes-client-python/mkdocs.yml

StreamPipes Committer

I acknowledge that I am a maintainer/committer of the Apache StreamPipes project.

@tenthe tenthe added good first issue Good for newcomers python Pull requests that update Python code labels Jan 12, 2023
@bossenti bossenti added this to the 1.0.0 milestone Jan 12, 2023
@Pranjul2002
Copy link

hey, i am new to open source and i want to start my journey in open source project.
I would like to work on this issue,can you guide me to this issue.

@dominikriemer
Copy link
Member

Hi @Pranjul2002 and welcome!

The following steps would be needed:

  1. The correct white logo can be found at https://github.com/apache/streampipes/blob/dev/ui/deployment/dev/img/logo-navigation.png
  2. Fork the website project from https://github.com/apache/streampipes-website
  3. In the website repo, replace the old logo with the new logo under https://github.com/apache/streampipes-website/tree/dev/website/img (sp-logo-white-right)
  4. Create your first PR in StreamPipes ;-)

Please ask if you have any further questions!

@Pranjul2002
Copy link

Pranjul2002 commented Jan 12, 2023

so basically i have to replace logo under https://github.com/apache/streampipes-website/tree/dev/website/img (sp-logo-white-right)with new one.

@bossenti
Copy link
Contributor

@Pranjul2002 exactly

@parthsali
Copy link
Contributor

Hey @bossenti, I think I can fix this issue. Can I start working on it now?

@bossenti
Copy link
Contributor

@parthsali sure, that would be great 👍

@parthsali
Copy link
Contributor

I changed the logo, but It is not visible as the background is also white. What should I do @bossenti?

img

@bossenti
Copy link
Contributor

Then you replaced probably the wrong one ;)
This one needs to be updated/replaced: https://github.com/apache/streampipes-website/blob/dev/website/img/sp-logo-white-right.png

@parthsali
Copy link
Contributor

parthsali commented Jan 14, 2023

The correct logo is white, is that right?

@bossenti
Copy link
Contributor

Yes, I understood the issue.
But you probably replaced the file sp-logo-color.png right?
This should stay as it is, because this is the right and current logo of StreamPipes in colors.
The only one that needs to updated is the white version of the logo (sp-logo-white-right.png).
The one at https://github.com/apache/streampipes-website/tree/dev/website/img still uses the old icon.
The white version of the logo is used in the docs of our Python client as described above.

@parthsali
Copy link
Contributor

My apologies, I just messed up : (

@parthsali
Copy link
Contributor

hey @bossenti, The PR has been sent and the old logo has been replaced with the new one. Please check if is it correct.

@bossenti bossenti linked a pull request Jan 15, 2023 that will close this issue
tenthe added a commit that referenced this issue Jan 16, 2023
[#1088] Fix linkt to StreamPipes logo in Mkdocs
@bossenti bossenti modified the milestones: 1.0.0, 0.91.0 Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers python Pull requests that update Python code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants