Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification counter is not reset #1533

Closed
bossenti opened this issue Apr 29, 2023 · 2 comments · Fixed by #1785
Closed

Notification counter is not reset #1533

bossenti opened this issue Apr 29, 2023 · 2 comments · Fixed by #1785
Assignees
Labels
backend Everything that is related to the StreamPipes backend bug Something isn't working ui Anything that affects the UI
Milestone

Comments

@bossenti
Copy link
Contributor

Apache StreamPipes version

dev (current development state)

Affected StreamPipes components

Backend, UI

What happened?

When deleting a pipeline that sends notifications, the messages are no longer available in the notifications overview.
However, the number of unread notifications remains and is not reset.

notification-counter

How to reproduce?

see above

Expected behavior

From my point of view there are two alternatives:

a) the notification counter is reset as well
b) the notifications are not deleted automatically when removing the associated pipeline

Additional technical information

No response

Are you willing to submit a PR?

None

@bossenti bossenti added the bug Something isn't working label Apr 29, 2023
@bossenti bossenti added this to the 1.0.0 milestone Apr 29, 2023
@bossenti bossenti added ui Anything that affects the UI backend Everything that is related to the StreamPipes backend labels Apr 29, 2023
@dominikriemer
Copy link
Member

Hi @bossenti
Currently, notifications are bound to a pipeline so that notifications are not shown if a pipeline is no longer present. I would see two options to solve this:

  1. Notifications that belong to a pipeline are deleted once the pipeline is deleted.
  2. We rewrite the notification module so that notifications are not bound to a pipeline, but could potentially also be created by other parts of the application. Notifications in the notification view would then not be organized by pipelines, but would include all notifications assigned to the user and maybe could be filtered by a notification type.

Since I think existing notification should not just disappear as in option 1, I tend to prefer 2. What do you think?

@bossenti
Copy link
Contributor Author

I agree with you that option 2 is the way to go hear.
But with the current implementation it is not possible to see/access the notifications once the pipeline is deleted right?
So until option 2 is implemented, option 1 might be good short-term solution? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Everything that is related to the StreamPipes backend bug Something isn't working ui Anything that affects the UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants