Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datetime selector in Data Explorer has issues with 12 am #1938

Closed
bossenti opened this issue Sep 15, 2023 · 2 comments · Fixed by #1941
Closed

Datetime selector in Data Explorer has issues with 12 am #1938

bossenti opened this issue Sep 15, 2023 · 2 comments · Fixed by #1941
Assignees
@muyangye
Labels
bug Something isn't working ui Anything that affects the UI
Milestone
0.93.0

Comments

@bossenti
Copy link
Contributor

Apache StreamPipes version

dev (current development state)

Affected StreamPipes components

UI

What happened?

When selecting a datetime in the data explorer, e.g., to filter data for a certain period of time, values between 12 AM and 1 AM cause a confusing representation.

How to reproduce?

When selecting a datetime within the data explorer
image

from 12 AM on
image
the value is then converted to 24:00 which is confusing.
image

Even worse, when selecting a time after 12 AM
image
it is displayed as 24:xx which is just wrong.
image

Expected behavior

Datetime values between 12 AM and 1 AM should be displayed as 00:xy.

Additional technical information

No response

Are you willing to submit a PR?

None
@bossenti bossenti added bug Something isn't working ui Anything that affects the UI labels Sep 15, 2023
@bossenti bossenti added this to the 0.93.0 milestone Sep 15, 2023
@muyangye muyangye mentioned this issue Sep 18, 2023
Merged
@muyangye
Copy link
Member

Hi @bossenti, I found the root cause of the problem. The backend unix timestamp is correct despite showing 24:xx, so the filter by time should still work. I have submitted a one line change PR that should fix the display problem caused by browser (tested on Chrome and Edge).

@bossenti
Copy link
Contributor Author

thanks a lot for picking this up @muyangye 🙏🏼

@bossenti bossenti linked a pull request Sep 19, 2023 that will close this issue
fix(#1938): fix datetime representation in Data Explorer #1941
Merged
bossenti pushed a commit that referenced this issue Sep 19, 2023
@muyangye
fix(#1938): fix datetime representation in Data Explorer (#1941)
6c9a568 
* implement new round processor

* add English locale, icon, and documentation

* fix checkstyle

* support different rounding modes

* add rounding mode in documentation

* fix time display
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@muyangye muyangye

Labels
bug Something isn't working ui Anything that affects the UI
Projects
None yet
Milestone
0.93.0
Development

Successfully merging a pull request may close this issue.

fix(#1938): fix datetime representation in Data Explorer muyangye/streampipes
2 participants
@bossenti @muyangye