[hotfix] Remove unused message interface #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenthe
added
enhancement
bossenti
approved these changes
Jan 4, 2023
There was a problem hiding this comment.
From my point of view it's fine to remove them
I can also do not find any usage of these interfaces.
Currently we have flagged it with no release note, do think this is valid @tenthe?
Or is it something that we want to communicate as breaking change in case this is used somewhere?
dominikriemer
approved these changes
Jan 4, 2023
|
I think this is some legacy code that is not used anymore. So I do not think we need it in the release notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
I removed a package with the two interfaces
IMessageListener&IMessagePublisherin the modulestreampipes-commons.They are not used within our code base.
@Reviewer, please confirm it is safe to delete.
Remarks
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no