Sp 1058 #1061
Merged
Sp 1058 #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenthe
approved these changes
Jan 9, 2023
| @@ -21,7 +21,7 @@ | |||
|
|
|||
| public class ElementIdGenerator { | |||
|
|
|||
| private static final String prefix = "urn:streampipes.apache.org:spi:"; | |||
There was a problem hiding this comment.
Could it be that we need an update script, or does this change only affect newly created IDs?
There was a problem hiding this comment.
Thanks for reviewing! This should not affect existing IDs.
I will create a migration script to cleanup existing models in the database as well.
bossenti
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR improves the streampipes model by removing obsolete or unused classes and removes two top-level objects
AbstractStreamPipesEntityandUnnamedStreamPipesEntity. This reduces inheritance with the goal to make the model ready for cross-language data exchange.Remarks
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no