Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the Kafka broker in Python #1363

Merged
merged 4 commits into from Mar 11, 2023
Merged

Add support for the Kafka broker in Python #1363

merged 4 commits into from Mar 11, 2023

Conversation

dominikriemer
Copy link
Member

@dominikriemer dominikriemer commented Feb 28, 2023 •
edited by bossenti

Purpose

This PR introduces support for the Kafka broker within StreamPipes Python.
With this a user is able to implement StreamPipes functions that interact with Kafka as a message broker.

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@github-actions github-actions bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Feb 28, 2023
@bossenti bossenti added the enhancement New feature or request label Mar 1, 2023
@dominikriemer dominikriemer marked this pull request as ready for review March 6, 2023 20:30
@bossenti bossenti self-requested a review March 6, 2023 20:35
@bossenti bossenti changed the title Improve python client Add support for the Kafka broker in Python Mar 8, 2023
@bossenti bossenti modified the milestones: 0.91.0, 1.0.0 Mar 8, 2023
@bossenti
Copy link
Contributor

bossenti commented Mar 8, 2023

@dominikriemer @SvenO3 Would you mind to check the examples if we somewhere explicitly exclude other brokers than NATS?

@SvenO3
Copy link
Contributor

SvenO3 commented Mar 9, 2023

@dominikriemer @SvenO3 Would you mind to check the examples if we somewhere explicitly exclude other brokers than NATS?

I can have a look at this.

@dominikriemer dominikriemer merged commit 7fe524e into dev Mar 11, 2023
@dominikriemer dominikriemer deleted the improve-python-client branch March 11, 2023 12:59
@bossenti bossenti modified the milestones: 1.0.0, 0.91.0 Mar 11, 2023
bossenti pushed a commit that referenced this pull request Mar 11, 2023
@dominikriemer @SvenO3 @bossenti
Add support for the Kafka broker in Python (#1363)
4714036 
* Update data model

* Support Kafka as messaging protocol in Python client (#1362)

* Reformat code (#1362)

* Update broker __init__

---------

Co-authored-by: Sven Oehler <oehler.sven@web.de>
Co-authored-by: Sven Oehler <43231162+SvenO3@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenthe tenthe tenthe approved these changes

@bossenti bossenti bossenti approved these changes

Assignees

@dominikriemer dominikriemer

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Milestone
0.91.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dominikriemer @bossenti @SvenO3 @tenthe