Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1113] Added buttons to start and stop all adapters #1441

Merged
merged 3 commits into from
Mar 28, 2023

Conversation

purplesmurf45
Copy link
Contributor

@purplesmurf45 purplesmurf45 commented Mar 22, 2023

Purpose

As discussed in #1113, this PR adds start all adapters and stop all adapters buttons on the connect page, similar to the start all pipelines and stop all pipelines buttons on the pipelines page.

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@github-actions github-actions bot added the ui Anything that affects the UI label Mar 22, 2023
@purplesmurf45 purplesmurf45 changed the title [WIP][#1113] Added buttons to start and stop all adapters [WIP] [#1113] Added buttons to start and stop all adapters Mar 22, 2023
@purplesmurf45
Copy link
Contributor Author

Hi, @dominikriemer and @tenthe, could you please review this PR? Please let me know if anything needs to be changed or added!

Copy link
Member

@dominikriemer dominikriemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @purplesmurf45!
I did a rough first review and raised a few questions :-)

@purplesmurf45 purplesmurf45 changed the title [WIP] [#1113] Added buttons to start and stop all adapters [#1113] Added buttons to start and stop all adapters Mar 22, 2023
@purplesmurf45
Copy link
Contributor Author

@dominikriemer I have made the requested changes. Can you please check now? Let me know if anything else needs revising!

@tenthe
Copy link
Contributor

tenthe commented Mar 23, 2023

Hello @purplesmurf45,
thank you very much for the PR. Maybe we can directly create a cypress e2e test for this new functionality.
My suggestion for the test is:

  • Create two adapters
  • Click on the button Stop all adapters
  • Click on the button Start all adapters
  • Confirm that the live data arrives

You can find a sample test in [1].
I am happy to assist you if you need help.

[1] https://github.com/apache/streampipes/blob/dev/ui/cypress/tests/adapter/editAdapter.smoke.spec.ts

@github-actions github-actions bot added the testing Relates to any kind of test (unit test, integration, or E2E test). label Mar 26, 2023
@purplesmurf45
Copy link
Contributor Author

@tenthe @dominikriemer I have added cypress tests for the newly added buttons. Could you please review the latest changes whenever you are free?

@dominikriemer
Copy link
Member

@tenthe can you please have a look at the tests?
I'm not sure why CI is not triggering all smoke tests.

@tenthe
Copy link
Contributor

tenthe commented Mar 28, 2023

@purplesmurf45 thanks a lot for this great PR.
Really cool that it also works directly with the Cypress test 🚀

@tenthe tenthe merged commit ce1d95f into apache:dev Mar 28, 2023
1 check passed
@bossenti bossenti linked an issue Apr 2, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Relates to any kind of test (unit test, integration, or E2E test). ui Anything that affects the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add buttons to start and stop all adapters
3 participants