Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1259] verify authentication on startup of python client #1557

Merged
merged 6 commits into from
May 9, 2023
Merged

[1259] verify authentication on startup of python client #1557

merged 6 commits into from
May 9, 2023

Conversation

bossenti
Copy link
Contributor

@bossenti bossenti commented May 7, 2023

Purpose

This PR introduces a direct API call for the StreamPipesClient when initialized. This API call is introduced for the reasons:

  1. it requires authentication and therefore allows to provide immediate feedback whether the passed credentials are valid or not.
  2. it retrieves the version the connected StreamPipes instance is running on. This will be used in subsequent work, so the client can assess which of it's features are compatible with the connected StreamPipes instance.

fixes #1259

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@bossenti
feature(#1259): implement version endpoint
fc33486 
Signed-off-by: bossenti <bossenti@posteo.de>
@bossenti
chore: reformatting
5bbe928 
Signed-off-by: bossenti <bossenti@posteo.de>
@bossenti
fix: typos
2ea31ca 
Signed-off-by: bossenti <bossenti@posteo.de>
@bossenti
[1259] retrieve version on start-up to verify authentication
a1e4041 
Signed-off-by: bossenti <bossenti@posteo.de>
@bossenti
reorder imports
a2f35ff 
Signed-off-by: bossenti <bossenti@posteo.de>
@bossenti
feature(1259): adapt tests
ff4f3ad 
Signed-off-by: bossenti <bossenti@posteo.de>
@bossenti bossenti linked an issue May 7, 2023 that may be closed by this pull request
Verify authentication on startup of Python client #1259
Closed
@bossenti bossenti changed the title 1259 verify authentication on startup of python client [1259] verify authentication on startup of python client May 7, 2023
@github-actions github-actions bot added python Pull requests that update Python code testing Relates to any kind of test (unit test, integration, or E2E test). labels May 7, 2023
@bossenti bossenti merged commit f8f8e51 into dev May 9, 2023
15 checks passed
@bossenti bossenti deleted the 1259-verify-authentication-on-startup-of-python-client branch May 9, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenthe tenthe tenthe approved these changes

@SvenO3 SvenO3 SvenO3 approved these changes

@dominikriemer dominikriemer Awaiting requested review from dominikriemer

Assignees
No one assigned
Labels
python Pull requests that update Python code testing Relates to any kind of test (unit test, integration, or E2E test).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify authentication on startup of Python client
3 participants
@bossenti @tenthe @SvenO3