-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CSS assets to ease configuration of custom layouts #1660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just found two CSS code lines which I think that can be removed.
Cheers,
Philipp
@@ -27,7 +27,7 @@ | |||
.icon-stand { | |||
max-height: calc(100vh - 148px); | |||
overflow-y: auto; | |||
background: var(--color-bg-1); | |||
//background: var(--color-bg-1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be removed?
ui/src/scss/sp/main.scss
Outdated
|
||
vertical-align: middle; | ||
} | ||
|
||
.disabled { | ||
/*opacity : 0.3;*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this also be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just found two CSS code lines which I think that can be removed.
Cheers,
Philipp
* [hotfix] Remove unused CSS, improve theming * Add template variables file to gitignore * Add variables template file to gitignore * Replace variable template file in prebuild script * Remove comments * Add prebuild script to postinstall * Add prebuild files to prettierignore
Purpose
Remove some unused CSS and extract CSS variables to ease configuration of custom layouts
Remarks
PR introduces (a) breaking change(s): no
PR introduces (a) deprecation(s): no