Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CSS assets to ease configuration of custom layouts #1660

Merged
merged 9 commits into from
Jun 13, 2023

Conversation

dominikriemer
Copy link
Member

Purpose

Remove some unused CSS and extract CSS variables to ease configuration of custom layouts

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@github-actions github-actions bot added javascript Pull requests that update Javascript code ui Anything that affects the UI labels Jun 5, 2023
Copy link
Contributor

@tenthe tenthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found two CSS code lines which I think that can be removed.
Cheers,
Philipp

@@ -27,7 +27,7 @@
.icon-stand {
max-height: calc(100vh - 148px);
overflow-y: auto;
background: var(--color-bg-1);
//background: var(--color-bg-1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be removed?


vertical-align: middle;
}

.disabled {
/*opacity : 0.3;*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this also be removed?

Copy link
Contributor

@tenthe tenthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found two CSS code lines which I think that can be removed.
Cheers,
Philipp

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Jun 6, 2023
@dominikriemer dominikriemer merged commit 31a5d2d into dev Jun 13, 2023
15 checks passed
@dominikriemer dominikriemer deleted the improve-css branch June 13, 2023 11:52
@bossenti bossenti removed the dependencies Pull requests that update a dependency file label Jun 13, 2023
@bossenti bossenti changed the title Improve css Improve CSS assets to ease configuration of custom layouts Jun 13, 2023
@bossenti bossenti added this to the 0.93.0 milestone Jun 13, 2023
jjbiggins pushed a commit to jjbiggins/streampipes that referenced this pull request Jul 5, 2023
* [hotfix] Remove unused CSS, improve theming

* Add template variables file to gitignore

* Add variables template file to gitignore

* Replace variable template file in prebuild script

* Remove comments

* Add prebuild script to postinstall

* Add prebuild files to prettierignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code ui Anything that affects the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants