Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce sink for MS Teams #2248

Merged
merged 7 commits into from
Dec 1, 2023
Merged

introduce sink for MS Teams #2248

merged 7 commits into from
Dec 1, 2023

Conversation

bossenti
Copy link
Contributor

Purpose

This PR introduces a dedicated sink that allows sending messages to MS Teams.Leveraging Teams' webhook capabilities, this feature enables users to input messages through both a simple and advanced mode. The simple mode facilitates the entry of plain text messages, while the advanced mode accepts JSON text, empowering users to leverage Microsoft's action cards for richer interaction.

Beyond the primary feature, this PR encompasses two minor refactoring enhancements:

  1. Eliminates redundant occurrences by removing the description as a hint for secret input fields in the UI.
  2. Introduces static properties facilitating the definition of multiline and placeholder capabilities.

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@bossenti bossenti added enhancement New feature or request pipeline elements Relates to pipeline elements labels Nov 30, 2023
@bossenti bossenti added this to the 0.95.0 milestone Nov 30, 2023
@github-actions github-actions bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code ui Anything that affects the UI backend Everything that is related to the StreamPipes backend documentation Everything related to documentation testing Relates to any kind of test (unit test, integration, or E2E test). labels Nov 30, 2023
@tenthe tenthe self-requested a review November 30, 2023 10:00
tenthe
tenthe requested changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@tenthe tenthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. The PR looks good to me, and this is a very cool feature.
I have some minor omments on the code, we can discuss them in the comments.

...ns-jvm/src/main/java/org/apache/streampipes/sinks/notifications/jvm/msteams/MSTeamsSink.java Outdated Show resolved Hide resolved
...ns-jvm/src/main/java/org/apache/streampipes/sinks/notifications/jvm/msteams/MSTeamsSink.java Outdated Show resolved Hide resolved
...ns-jvm/src/main/java/org/apache/streampipes/sinks/notifications/jvm/msteams/MSTeamsSink.java Outdated Show resolved Hide resolved
...ns-jvm/src/main/java/org/apache/streampipes/sinks/notifications/jvm/msteams/MSTeamsSink.java Outdated Show resolved Hide resolved
@bossenti bossenti merged commit 2d21904 into dev Dec 1, 2023
19 checks passed
@bossenti bossenti deleted the feat-ms-teams-sink branch December 1, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenthe tenthe tenthe approved these changes

Assignees
No one assigned
Labels
backend Everything that is related to the StreamPipes backend dependencies Pull requests that update a dependency file documentation Everything related to documentation enhancement New feature or request java Pull requests that update Java code pipeline elements Relates to pipeline elements testing Relates to any kind of test (unit test, integration, or E2E test). ui Anything that affects the UI
Projects
None yet
Milestone
0.95.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bossenti @tenthe