Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove deprecated method fromResources #2261

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

bossenti
Copy link
Contributor

@bossenti bossenti commented Dec 1, 2023

Purpose

This PR removes the method fromResources of the Labels class that has been marked for deprecated since 0.90.0.

Deprecations

The following methods have been deprecated since 0.90.0 and are now removed:

  • Label fromResources(String resourceIdentifier, String resourceName)

This can be replaced by working with the withLocales() method of processing element builders.

Remarks

PR introduces (a) breaking change(s): <yes/no>

PR introduces (a) deprecation(s): <yes/no>

@bossenti bossenti added this to the 0.95.0 milestone Dec 1, 2023
@bossenti bossenti added the deprecation Assigned to pull requests or issues that introduce a deprecation. label Dec 1, 2023
@github-actions github-actions bot added java Pull requests that update Java code backend Everything that is related to the StreamPipes backend labels Dec 1, 2023
@dominikriemer dominikriemer merged commit 581fd25 into dev Dec 1, 2023
18 checks passed
@dominikriemer dominikriemer deleted the remove-deprecation-labels branch December 1, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Everything that is related to the StreamPipes backend deprecation Assigned to pull requests or issues that introduce a deprecation. java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants