refactor: abstract data explorer modules from Influx-related code #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
tenthe
reviewed
Apr 30, 2024
streampipes-commons/src/main/java/org/apache/streampipes/commons/constants/Envs.java
Outdated
Show resolved
Hide resolved
| import org.apache.streampipes.dataexplorer.api.IDataExplorerManager; | ||
| import org.apache.streampipes.dataexplorer.influx.DataExplorerManagerInflux; | ||
|
|
||
| public enum DataExplorerDispatcher { |
There was a problem hiding this comment.
Does it make sense to change this to a class that we can more easily mock for testing instead of a singleton?
There was a problem hiding this comment.
I have changed DataExplorerDispatcher to a regular class, check if that suits your expectations
.../main/java/org/apache/streampipes/dataexplorer/management/SupportedDataExplorerStorages.java
Outdated
Show resolved
Hide resolved
tenthe
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR continues the work of #2795 and abstracts the data explorer code from Influx-specific implementations. The idea is that whenever we want to interact with our data explorer storage we do not point to storage-specific implementations but use the
DataExplorerDispatcherinstead. TheDataExplorerDispatchergives aces to an an instance ofDataExplorerManagerwhich is tied to the underlying storage dependent on the configuration of StreamPipes. Therefore, this PR introduces the environment variableSP_TS_STORAGEwhich determines the storage to be used and defaults toinfluxDB.As for now, Influx is the only storage supported but this allows us to better separate our codebase and to integrate other time series storages as well.
Remarks
PR introduces (a) breaking change(s): yes
PR introduces (a) deprecation(s): no
Breaking Changes
This PR strongly moves files between different modules and therefore import paths might change, especially with respect to the module
streampipes-data-explorer-influx. This PR does not have any affect on the behavior or any feature of StreamPipes.