Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/refactor class hierarchy python client #909

Merged
merged 3 commits into from
Dec 28, 2022
Merged

Chore/refactor class hierarchy python client #909

merged 3 commits into from
Dec 28, 2022

Conversation

bossenti
Copy link
Contributor

Purpose

Introduce BaseElement for a cleaner class hierarchy

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@bossenti
remove trailing white lines
720c9cf 
Signed-off-by: bossenti <bossenti@posteo.de>
@bossenti
add make command to run pre-commit hook
4f76c07 
Signed-off-by: bossenti <bossenti@posteo.de>
@bossenti
introduce BaseElement for a cleaner class hierarchy
fdfd9de 
Signed-off-by: bossenti <bossenti@posteo.de>
@bossenti bossenti added python Pull requests that update Python code refactoring Indicates when a pull request or issue contains larger refactoring aspects. no release note Issues and PR. Add if they should not be contained in the release notes (e.g., minor refactorings). labels Dec 28, 2022
@bossenti bossenti added this to the 1.0.0 milestone Dec 28, 2022
@bossenti bossenti merged commit 9cd4299 into dev Dec 28, 2022
@bossenti bossenti deleted the chore/refactor-class-hierarchy-python-client branch December 28, 2022 15:49
@bossenti bossenti modified the milestones: 1.0.0, 0.91.0 Jan 30, 2023
@bossenti bossenti self-assigned this Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenthe tenthe tenthe approved these changes

Assignees

@bossenti bossenti

Labels
no release note Issues and PR. Add if they should not be contained in the release notes (e.g., minor refactorings). python Pull requests that update Python code refactoring Indicates when a pull request or issue contains larger refactoring aspects.
Projects
None yet
Milestone
0.91.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bossenti @tenthe