Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of Consul env variables (#953) #954

Merged
merged 1 commit into from
Dec 30, 2022
Merged

Improve handling of Consul env variables (#953) #954

merged 1 commit into from
Dec 30, 2022

Conversation

dominikriemer
Copy link
Member

@dominikriemer dominikriemer commented Dec 30, 2022 •
edited
Loading

Purpose

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): yes

@dominikriemer dominikriemer linked an issue Dec 30, 2022 that may be closed by this pull request
Improve handling of Consul env variables #953
Closed
@dominikriemer
Copy link
Member Author

@bossenti should we also replace CONSUL_LOCATION in the python client to use SP_CONSUL_HOST instead?

@dominikriemer dominikriemer self-assigned this Dec 30, 2022
@dominikriemer dominikriemer added deprecation Assigned to pull requests or issues that introduce a deprecation. backend Everything that is related to the StreamPipes backend labels Dec 30, 2022
@dominikriemer dominikriemer added this to the 1.0.0 milestone Dec 30, 2022
@dominikriemer dominikriemer merged commit af23e43 into dev Dec 30, 2022
@dominikriemer dominikriemer deleted the SP-953 branch December 30, 2022 10:01
@bossenti
Copy link
Contributor

@bossenti should we also replace CONSUL_LOCATION in the python client to use SP_CONSUL_HOST instead?

If I am not mistaken, this is not yet used in the Python client. So we can directly use the new ENV name once we get to this point

@bossenti bossenti added no release note Issues and PR. Add if they should not be contained in the release notes (e.g., minor refactorings). and removed deprecation Assigned to pull requests or issues that introduce a deprecation. labels Dec 31, 2022
@bossenti bossenti modified the milestones: 1.0.0, 0.91.0 Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenthe tenthe tenthe approved these changes

Assignees

@dominikriemer dominikriemer

Labels
backend Everything that is related to the StreamPipes backend no release note Issues and PR. Add if they should not be contained in the release notes (e.g., minor refactorings).
Projects
None yet
Milestone
0.91.0
Development

Successfully merging this pull request may close these issues.

Improve handling of Consul env variables
3 participants
@dominikriemer @bossenti @tenthe