Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: list value localization #18

Merged
merged 13 commits into from Jul 30, 2014
Merged

Conversation

lukaszlenart
Copy link
Member

This is continuation of @abrin work started in #7

Closes WW-4295
Closes #7

adam brin and others added 12 commits March 18, 2014 07:36
 Locale Files.  Adding listValueKey attribute to checkboxList, radioMap, and
 select tags.

Issues:
This implementation uses the <@s.text> tag to handle the localization with an assignment. I presume this is less than idea, but I lack the knowledge of the Struts2 tag model that would suggest where to check for this on the valueStack or elsewhere.

Example:

public enum yesno {
YES, NO;
}

<@s.radio name="yes no" list="#{yesno.values()}" valueKey="name()" />

<!-- this will look for the name() in the locale file and emit the localized value for the label of the radio button.
updating java-backed bean
Conflicts:
	core/src/site/resources/tags/checkboxlist.html
@lukaszlenart
Copy link
Member Author

@abrin can you review the changes or test them locally? I don't see value in the changes right now as I don't now how do you want to use them. Check the provided test case in d67fce1

@asfgit asfgit merged commit d20c2f1 into develop Jul 30, 2014
asfgit pushed a commit that referenced this pull request Jul 30, 2014
Closes #18
@asfgit asfgit deleted the feature/WW-4295-localization branch July 30, 2014 07:19
kusalk added a commit that referenced this pull request Dec 27, 2023
Merge in BAM/struts2-atlassian from stash-WW-5340-ognl-guard to fork/6.3

* commit 'ef7ef2f08f73e6a56860932aaf1105fa1dd3daeb':
  WW-5340 Correct optimisation
  WW-5340 Refactor OgnlGuard to do the parsing
  WW-5340 Add unit tests
  WW-5340 Add validation to excluded node configuration
  WW-5340 Cache OgnlGuard result
  WW-5340 Make OgnlGuard a configurable bean
  WW-5340 Fix tests
  WW-5340 Introducing OGNL Guard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants