WW-4741: Do not create session #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test no session but with locale parameter
| } | ||
|
|
||
| return locale; |
There was a problem hiding this comment.
When shouldStore field is not false (i.e. we should store), shouldn't we forcefully create a session and store the locale? if we should not, shouldn't we return null here?
There was a problem hiding this comment.
Maybe we should forcefully create the session but I would leave that to a user, if there was no session just ignore (a user fault). And returning null can break action processing as then the null will be set in ActionContext
test not create when no session
|
LGTM 👍 Nice catch! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves WW-4741