Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WW-4915 Replace deprecated commons-lang3 classes #208

Merged
merged 3 commits into from
Mar 16, 2018
Merged

WW-4915 Replace deprecated commons-lang3 classes #208

merged 3 commits into from
Mar 16, 2018

Conversation

aleksandr-m
Copy link
Contributor

@aleksandr-m aleksandr-m commented Feb 5, 2018 •
edited
Loading

org.apache.commons.lang3.StringEscapeUtils.escapeXml was replaced with org.apache.commons.text.StringEscapeUtils.escapeXml10 which escapes more characters and potentially can break some things.
@apache/struts-committers

@lukaszlenart
Copy link
Member

This introduces a new dependency and I would wait with merging this till 2.6, wdyt?

@coveralls
Copy link

coveralls commented Feb 5, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 46.638% when pulling dac6244 on aleksandr-m:feature/lang_to_text into eed364f on apache:master.

@aleksandr-m
Copy link
Contributor Author

Sure. The escapeXml change will also be more reasonable then.

@lukaszlenart
Copy link
Member

LGTM 👍

@lukaszlenart lukaszlenart merged commit 7f3c09c into apache:master Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@aleksandr-m @lukaszlenart @coveralls