Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance after_success for Travis CI #280

Merged
merged 1 commit into from
Nov 22, 2018

Conversation

sepe81
Copy link
Contributor

@sepe81 sepe81 commented Nov 21, 2018

Use default bash if-then-else block with semicolon after each command and fix spelling for "incompatibility".

Don't do mvn clean b/c we need the test results for the following tasks and don't need to rebuild everything.

@coveralls
Copy link

coveralls commented Nov 21, 2018

Coverage Status

Coverage remained the same at 46.893% when pulling 352f509 on sepe81:travis-after_success into 3bf9546 on apache:master.

Use default bash if-then-else block with semicolon after each command
and fix spelling for "incompatibility".

Don't do `mvn clean` b/c we need the test results for the following
tasks and don't need to rebuild everything.
@sepe81
Copy link
Contributor Author

sepe81 commented Nov 21, 2018

@lukaszlenart the api key for UpdateImpact seems to be ignored. At the end of the relevant Travis CI build I see Please define the api key. You can find it on UpdateImpact.com.

Edit: Maybe this just works for apache:<branches> and not for external PRs!?

.travis.yml Show resolved Hide resolved
@lukaszlenart
Copy link
Member

@sepe81 we can ignore the UpdateImpact plugin, I mostly added it to have a badge with number of dependencies ;-)

@yasserzamani
Copy link
Member

osm! about two minutes save in jdk8 job, thanks a lot!

@yasserzamani yasserzamani merged commit 3ff6fd8 into apache:master Nov 22, 2018
@sepe81 sepe81 deleted the travis-after_success branch November 22, 2018 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants