Fix sonar warnings for DefaultTypeConverter #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method uses a string under the covers to eliminate floating point rounding errors.
aleksandr-m
reviewed
Dec 18, 2018
core/src/main/java/com/opensymphony/xwork2/conversion/impl/DefaultTypeConverter.java
Outdated
Show resolved
Hide resolved
sepe81
commented
Dec 19, 2018
core/src/test/java/com/opensymphony/xwork2/conversion/impl/XWorkBasicConverterTest.java
Show resolved
Hide resolved
I insinuate that the non primitive BigInteger and BigDecimal types should also return default values for null input. Rename the map to `baseTypeDefaults for better understanding and remove the check for `isPrimitive` b/c this seemed to be kind of optimization but breaked the check for included non-primitive types. B/c the unit tests run successfully, we can use the existing default fields ZERO.
|
If no objections LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.