Equivalent to PR#309, but for the master (2.6.x) branch. #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed most of the logging added in PR#292. - Left the added logging for the setExcludedPatterns and setAcceptedPatterns methods in their respective modules. L. Lenart's comment indicated their benefit outweighs overhead (not something that changes often). Made the if-else blocks consistent with preferred styling for the log blocks. - Removed a dangling "/**" start comment tag with no proper close (and the whitespace between it and the next "/**") in the OgnlValueStack module.
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent to PR#309 (for 2.5.x), but this one is for the master (2.6.x) branch.
setExcludedPatternsandsetAcceptedPatternsmethods in their respective modules (please see PR#309 for justification). Made the if-else blocks consistent with preferred styling for the log blocks.OgnlValueStackmodule.