Minor follow-up changes to PR #371 #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added some additional exclusions in struts-default.xml. - added log warning that specifies the value of maxLength involved if applyExpressionMaxLength(maxLength) fails. - added null guards to two handleOgnlException() methods that could result in an NPE with apache#371 changes (a null OgnlException parameter was permissible previously, correct or not).
|
Hello Apache Struts Team. This is a follow-up PR based on earlier comments in a PR#371 review. The changes are straightforward and should be very low risk. The build succeeds locally and a quick run through the showcase application didn't reveal any failures either. @lukaszlenart , according to the developer list you are considering a Struts 2.5.21 release sometime soon. Could you please review this PR and consider it for inclusion in 2.5.21 ? |
|
Coveralls claims that coverage diminished in applyExpressionMaxLength(maxLength). |
- added unit test (hoping to make coveralls happy).
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor follow-up changes to PR #371