Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WW-5064] Move XWork Spring support into struts2-spring-plugin #498

Merged
merged 1 commit into from
Sep 24, 2021
Merged

[WW-5064] Move XWork Spring support into struts2-spring-plugin #498

merged 1 commit into from
Sep 24, 2021

Conversation

sdutry
Copy link
Member

@sdutry sdutry commented Sep 24, 2021

Jira Issue: WW-5064

Moved over the spring related classes that were still in core to the spring plugin.

Side-effect:

  • had to move over the SecurityMemberAccessProxyTest too, since the ProxyUtil relies heavily on the spring related proxies.

Currently bluntly kept the original packages. If you want it moved from xwork packages to struts2 packages, just let me know and i'll change them.

@lukaszlenart
Copy link
Member

Currently bluntly kept the original packages

That's fine, user won't be confused (too much ;-) )

Copy link
Member

@lukaszlenart lukaszlenart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lukaszlenart lukaszlenart merged commit e681d53 into apache:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants