fixed flakiness in JacksonXmlHandlerTest.java #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed flakiness in JacksonXmlHandlerTest.java
lukaszlenart
reviewed
Nov 2, 2021
plugins/rest/src/test/java/org/apache/struts2/rest/handler/JacksonXmlHandlerTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
By running the following command:
mvn -pl plugins/rest/ edu.illinois:nondex-maven-plugin:1.1.2:nondex -Dtest=org.apache.struts2.rest.handler.JacksonXmlHandlerTest,testObjectToXmlmethod will fail sometimes. This is becausefromObject()method ofJacksonXmlHandlerusescom.fasterxml.jackson.dataformat.xml.XmlMapper, whose marshal strategy that serializes the object is non-deterministic. Thus, the output oftoString()method of the serialized xml object is non-deterministic. I fixed the bug by checking the output contains all components of the xml object and the expected length.