WW-5352 Ensure StrutsParameter compatibility with TypeConversion setters

[kusalk]

WW-5352

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
97.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[kusalk]

@lukaszlenart

I was hoping you could clear up some confusion of mine as I'm not well versed in how the Struts TypeConversion functionality behaves. I'm trying to understand whether it is possible to set a collection of Model class objects on an Action where only a setter exists?

For example - for the following action,

public class ExampleAction {
    // Configured with some TypeConverter
    public void setModels(List<Model> models) {
        this.models = models;
    }

    public static class Model {
        public String name;
    }
}

is it possible to configure a TypeConverter that would allow the following request to execute as intended?
example.action?models[0].name=kusal&models[1].name=lukasz

If so, I may need to tweak the StrutsParameter mechanism to also recognise annotations on Setters (which is what this draft PR does).

[lukaszlenart]

This should work without a converter, the Model has the default constructor and Struts uses OGNL logic to create and extend lists

[kusalk]

So I tried testing this, and it seems without a matching getter, the list will not be populated. It will simply be set to an empty list.

The current @StrutsParameter logic only checks for annotations on getters when trying to set a collection or model class. My concern was that it might be possible to do this with only a setter. But if not, we can safely close this PR.

[kusalk]

I've just had a read of the following TypeConverter test and it seems it is only possible to set a List without a matching getter when using a serialized format.
core/src/test/java/com/opensymphony/xwork2/test/annotations/PersonActionTest.java

So in the earlier example I gave, the request would have to be a custom format as defined in the type converter, e.g.:
example.action?models=kusal:lukasz

So I think we are indeed okay to close this PR.