Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always run Sonar scan against the master branch #921

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Always run Sonar scan against the master branch #921

wants to merge 1 commit into from
+1 −1

Conversation

lukaszlenart
Copy link
Member

No description provided.

@kusalk
Copy link
Member

kusalk commented Apr 22, 2024 •
edited
Loading

I think we need to check the branch name (github.ref) and PR target branch (github.base_ref), and if either of those match 'master', run the workflow else skip it

@sepe81
Copy link
Contributor

sepe81 commented Jun 12, 2024

It would also be nice if the step "SonarCloud / Scan (push)" in the master of forked projects is skipped, as this always fails otherwise.

Error:  Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:4.0.0.4121:sonar (default-cli) on project struts2-parent: Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties, the 'SONAR_TOKEN' environment variable, or contact the project administrator to check the permissions of the user the token belongs to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@lukaszlenart @kusalk @sepe81