Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUBMARINE-1131. Remove deprecated API for k8s 1.25 #1071

Closed
wants to merge 5 commits into from

Conversation

cdmikechen
Copy link
Contributor

@cdmikechen cdmikechen commented Jun 17, 2023

What is this PR for?

PodSecurityPolicy will be removed in k8s 1.25
https://kubernetes.io/docs/reference/using-api/deprecation-guide/#psp-v125

So that we need to remove the PodSecurityPolicy support in 1.25 and try to use other ways to handle runAsUser.
https://kubernetes.io/docs/tasks/configure-pod-container/migrate-from-psp/
https://kubernetes.io/docs/concepts/security/pod-security-admission/

What type of PR is it?

Improvement

Todos

  • - Add k8s 1.25 in git workflow
  • - Change podSecurityPolicy.create default value to false
  • - ChangePodSecurityPolicy to Pod Security Admission (PCA) in 1.25

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-1131

How should this be tested?

CI test

Screenshots (if appropriate)

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? No

@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Merging #1071 (a9ed15d) into master (be4ecf2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1071   +/-   ##
=======================================
  Coverage   75.98%   75.98%           
=======================================
  Files         119      119           
  Lines        5000     5000           
=======================================
  Hits         3799     3799           
  Misses       1201     1201           
Flag Coverage Δ
python-integration 59.72% <ø> (ø)
python-unit 52.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cdmikechen cdmikechen requested a review from pingsutw June 22, 2023 11:43
@cdmikechen
Copy link
Contributor Author

@pingsutw
Hi~ For this PR, could you have time to do a validation in a k8s 1.25 environment (minikube or rancher) will work?

@asfgit asfgit closed this in b0d96b3 Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants