Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUBMARINE-1379. Fix a bug where tasks from missing k8s resources could not be deleted on the UI #1073

Closed
wants to merge 4 commits into from

Conversation

cdmikechen
Copy link
Contributor

What is this PR for?

If the backend CR is manually deleted, the submarine-server is not currently checking if the specified resource still exists, resulting in a situation where the experiment cannot be deleted in UI.

What type of PR is it?

Bug Fix

Todos

  • - Remove throwsApiException in Notebook, Experiment and Serve.
  • - Fixed a bug where deleting a record on the UI, the entire page data clear

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-1379

How should this be tested?

CI tests can cover code, but they can only represent processes that handle normal conditions.
I removed the method of throwing an 404 exception error (.throwsApiException()) when the resource does not exist, which results in the return of the status object.
In this way, we can return the result normally, even without this resource

Screenshots (if appropriate)

NA

Questions:

  • Do the license files need updating? No
  • Are there breaking changes for older versions? No
  • Does this need new documentation? No

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #1073 (03a7011) into master (b0d96b3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1073   +/-   ##
=======================================
  Coverage   67.27%   67.27%           
=======================================
  Files         128      128           
  Lines        6224     6224           
=======================================
  Hits         4187     4187           
  Misses       2037     2037           
Flag Coverage Δ
python-integration 54.20% <ø> (ø)
python-unit 48.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant