SUBMARINE-321. Add JobManager and SubmitterManager components #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangzhankun
reviewed
Dec 30, 2019
There was a problem hiding this comment.
Thanks @jiwq for the contribution. It looks good to me in general. I've several comments and please check them.
| * The replica spec for TFJob. It contains replicas, restart policy and pod template. | ||
| * The template describe the running instance for task. | ||
| */ | ||
| public class TFReplicaSpec { |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| * TensorFlow: Chief, Ps, Worker, Evaluator | ||
| * PyTorch: Master, Worker | ||
| */ | ||
| private Map<String, JobTaskSpec> taskSpecs; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
jiwq
commented
Dec 30, 2019
tangzhankun
reviewed
Dec 30, 2019
| /** | ||
| * The job task name, the range is [Chief, Ps, Worker, Evaluator, Master] | ||
| */ | ||
| private String name; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
It LGTM. +1. Thanks for your contribution. @jiwq |
yuanzac
reviewed
Dec 30, 2019
...s/commons-utils/src/main/java/org/apache/submarine/commons/utils/SubmarineConfiguration.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The JobManager is responsible for cache and schedule the job to submitter.
The SubmitterManager help to load the different submitter plugins.
What type of PR is it?
Feature
Todos
[ ] Hook REST server and JobManager
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-321
How should this be tested?
Screenshots (if appropriate)
Questions: