SUBMARINE-341. Add submarine server dockerfile #148
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingsutw
reviewed
Jan 12, 2020
| # Replace the mysql jdbc.url in the submarine-site.xml file with the link name of the submarine container | ||
| # `submarine-database` is submarine database container name | ||
| cp ${SUBMARINE_HOME}/conf/submarine-site.xml "${CURRENT_PATH}/tmp/" | ||
| sed -i ".bak" 's/127.0.0.1:3306/submarine-database:3306/g' "${CURRENT_PATH}/tmp/submarine-site.xml" |
There was a problem hiding this comment.
Thanks for the patch,@liuxunorg.
I got an error when running this line
error message:
sed: -e expression #1, char 1: unknown command: `.'
I change the command to sed -i.bak 's/127.0.0.1:3306/submarine-database:3306/g' "${CURRENT_PATH}/tmp/submarine-site.xml", and it works for me
| if [ ! -d "${SUBMARINE_HOME}/submarine-dist/target" ]; then | ||
| mkdir "${SUBMARINE_HOME}/submarine-dist/target" | ||
| fi | ||
| submarine_dist_exists=$(find -L "${SUBMARINE_HOME}/submarine-dist/target" -name "submarine-dist-${submarine_v}*.tar.gz") |
There was a problem hiding this comment.
It's better to use SUBMARINE_VERSION
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
In order to enable submarine to support deployment in k8s,
We need to enable each service of subarine to be deployed independently.
The problem that jira solves is that it can run the subarine server independently in docker.
Let users only need a docker command to run the submarine service.
like.,
What type of PR is it?
[Feature]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: