SUBMARINE-349. Support using existing artifacts to build mini-submarine image #158
Conversation
xunliu
changed the title
| @@ -49,7 +49,11 @@ else | |||
| WORKER_CMD="myvenv.zip/venv/bin/python mnist_distributed.py --steps 2 --data_dir /tmp/data --working_dir /tmp/mode" | |||
| fi | |||
|
|
|||
| SUBMARINE_VERSION=0.3.0-SNAPSHOT | |||
| SUBMARINE_VERSION=$SUBMARINE_VER | |||
There was a problem hiding this comment.
SUBMARINE_VERSION =${SUBMARINE_VER:-"0.3.0-SNAPSHOT"}
This way, So you can set default values.
There was a problem hiding this comment.
Yeah. Will simplify it.
| hadoop_v=2.9.2 | ||
| spark_v=2.4.4 | ||
| submarine_v=0.3.0-SNAPSHOT | ||
|
|
||
| submarine_v=$submarine_version |
There was a problem hiding this comment.
submarine_v =${submarine_version:-"0.3.0-SNAPSHOT"}
This way, So you can set default values.
| @@ -47,7 +47,11 @@ else | |||
| WORKER_CMD="myvenv.zip/venv/bin/python mnist_distributed.py --steps 2 --data_dir /tmp/data --working_dir /tmp/mode" | |||
| fi | |||
|
|
|||
| SUBMARINE_VERSION=0.3.0-SNAPSHOT | |||
| SUBMARINE_VERSION=$SUBMARINE_VER | |||
There was a problem hiding this comment.
SUBMARINE_VERSION =${SUBMARINE_VER:-"0.3.0-SNAPSHOT"}
This way, So you can set default values.
| @@ -17,8 +17,10 @@ | |||
|
|
|||
| # Below are configurable variables, please adapt base on your local environment. | |||
| # Version of submarine jar | |||
| SUBMARINE_VERSION=0.3.0-SNAPSHOT | |||
|
|
|||
| SUBMARINE_VERSION=$SUBMARINE_VER | |||
There was a problem hiding this comment.
SUBMARINE_VERSION =${SUBMARINE_VER:-"0.3.0-SNAPSHOT"}
This way, So you can set default values.
dev-support/mini-submarine/README.md
Outdated
| @@ -52,6 +52,26 @@ mvn clean install package -DskipTests | |||
| cd submarine/dev-support/mini-submarine/ | |||
| ./build_mini-submarine.sh | |||
| ``` | |||
| #### Package An Existing Release Candidates | |||
| When doing release, the release manager might needs to package a artifact candidatesin this docker image and public the image candidate for a vote. | |||
There was a problem hiding this comment.
candidatesin should be candidates in
There was a problem hiding this comment.
Thanks for catching this.
|
@tangzhankun |
What is this PR for?
The hard-coded submarine version(0.3.0-SNAPSHOT) in build_mini-submarine.sh is not convenient. When doing a release, we need the image to package a candidate artifacts like 0.3.0.
This JIRA is for extending the build script to package specified artifacts. Setting environment variable submarine_version and release_candidates_path can trigger this code path.
It will copy binary tarball with the submarine_version to the local dir and build the image.
What type of PR is it?
Improvement
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-349
How should this be tested?
Put submarine candidate aritifacts to a folder like "~/releases/submarine-release"
$ ls $release_candidates_path
submarine-dist-0.3.0-hadoop-2.9.tar.gz submarine-dist-0.3.0-src.tar.gz.asc
submarine-dist-0.3.0-hadoop-2.9.tar.gz.asc submarine-dist-0.3.0-src.tar.gz.sha512
submarine-dist-0.3.0-hadoop-2.9.tar.gz.sha512 submarine-dist-0.3.0-src.tar.gz
export submarine_version=0.3.0
export release_candidates_path=~/releases/submarine-release
./build_mini-submarine.sh
docker run -it -h submarine-dev --net=bridge --privileged -P local/mini-submarine:0.3.0 /bin/bash
In the container, check the submarine jar version is 0.3.0
Questions: