Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUBMARINE-281. Remove Chinese characters #188

Closed
wants to merge 1 commit into from
Closed

SUBMARINE-281. Remove Chinese characters #188

wants to merge 1 commit into from

Conversation

cchung100m
Copy link
Contributor

What is this PR for?

Remove Chinese characters from source code

What type of PR is it?

[Improvement]

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-281

How should this be tested?

https://travis-ci.com/cchung100m/submarine/builds/149643127

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@cchung100m cchung100m changed the title SUBMARINE-281. Remove chinese characters SUBMARINE-281. Remove Chinese characters Feb 19, 2020
xunliu
xunliu approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@xunliu
Copy link
Member

xunliu commented Feb 20, 2020

@cchung100m Thank you for contribution.
Will merge if no more comments.

jiwq
jiwq reviewed Feb 20, 2020
View reviewed changes
Copy link
Member

@jiwq jiwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd better make up more describe info for it. Thoughts?

@cchung100m
Copy link
Contributor Author

Hi @liuxunorg
Thanks for review.
Hi @jiwq
Sure, any suggestions/guidelines for more description info are welcome. :)

@asfgit asfgit closed this in cdb2e7f Feb 20, 2020
@cchung100m cchung100m deleted the SUBMARINE-281 branch February 20, 2020 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiwq jiwq jiwq left review comments

@xunliu xunliu xunliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cchung100m @xunliu @jiwq