Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUBMARINE-406. optimize travis #207

Closed
wants to merge 1 commit into from
Closed

SUBMARINE-406. optimize travis #207

wants to merge 1 commit into from

Conversation

xunliu
Copy link
Member

@xunliu xunliu commented Mar 7, 2020 •
edited

What is this PR for?

  1. Test cases are not fully covered in travis, and there is a problem of repeated tests. So we need to optimize and refactor travis test cases.
  2. Remove duplicate testing tasks in travis.
  3. Reduced test task time in travis.

What type of PR is it?

[Improvement | Refactoring]

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

image

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@xunliu xunliu requested a review from yuanzac March 7, 2020 15:58
tangzhankun
tangzhankun reviewed Mar 8, 2020
View reviewed changes
Copy link
Contributor

@tangzhankun tangzhankun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor question. Do we need to test VUE workbench？

@xunliu
Copy link
Member Author

xunliu commented Mar 8, 2020

One minor question. Do we need to test VUE workbench？

Wait for the NG version to be developed before deleting the VUE version.

xunliu
xunliu commented Mar 8, 2020
View reviewed changes
Copy link
Member Author

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge if no more comments.

@asfgit asfgit closed this in 33a1659 Mar 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangzhankun tangzhankun tangzhankun left review comments

@yuanzac yuanzac Awaiting requested review from yuanzac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xunliu @tangzhankun