SUBMARINE-74. Add tests to TensorFlowServiceSpec class #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cchung100m Thanks for the contribution. LGTM. One thing I'd like to add is that the yarn service runtime will be not our focus in the long term. |
|
Hi @tangzhankun Understood, thanks for the review and comments. :) |
|
@cchung100m At present, the community does not plan to invest too much effort in developing yarn service, so you can adjust your work goals in future PRs. |
xunliu
approved these changes
Mar 22, 2020
|
@liuxunorg Thanks for suggestions. I would align the work with the community's target. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add tests to TensorFlowServiceSpec class
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-74
How should this be tested?
https://travis-ci.org/github/cchung100m/submarine?utm_medium=notification&utm_source=github_status
Screenshots (if appropriate)
Questions: