Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUBMARINE-506. [SDK] Generate experiment Python SDK #296

Closed
wants to merge 5 commits into from

Conversation

pingsutw
Copy link
Member

What is this PR for?

Generate Experiment Python SDK

What type of PR is it?

[Feature]

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-506

How should this be tested?

https://github.com/pingsutw/hadoop-submarine/actions/runs/111931885

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Contributor

@tangzhankun tangzhankun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! @pingsutw It looks good to me. Only suggestions related to the document as below.

submarine-sdk/pysubmarine/submarine/job/README.md Outdated Show resolved Hide resolved
submarine-sdk/pysubmarine/submarine/job/README.md Outdated Show resolved Hide resolved
@pingsutw
Copy link
Member Author

@tangzhankun Thanks for the review.
I've updated the doc

@xunliu
Copy link
Member

xunliu commented May 23, 2020

@pingsutw I have a problem, of course, this problem does not hinder the merger of this PR.
Do we need to generate these interfaces through [swagger editor] (https://editor.swagger.io/) every time? Can it be directly integrated in the compile command? For example, the mvn command, I am not familiar with swagger, it is likely that my suggestion is not necessarily reasonable.

Just like the submarine-cloud module needs to be compiled with go, we pass
https://github.com/apache/submarine/blob/master/submarine-cloud/pom.xml#L64
Created a submarine-build mirroring tool and compiled it with the mvn command. Can swagger be compiled in a similar way.

Apply again, I am not familiar with swagger, it is likely that my suggestion is not necessarily reasonable.

@pingsutw
Copy link
Member Author

@liuxunorg Thanks for the review.
As we discuss offline, will file another JIRA ticket to automatically build swagger API instead of generating API manually

@tangzhankun
Copy link
Contributor

@liuxunorg thanks for the review. @kevin85421 Thanks for the contribution! I'll merge this soon.

@asfgit asfgit closed this in 931e147 May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants