This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 253
SUBMARINE-527. [SDK] Abstract client API #315
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found that Lines 180 to 195 in 0f281ca
http://submarine:8080/api/v1/experiment/logs output: {
"status": "OK",
"code": 200,
"success": true,
"message": null,
"result": [
{
"experimentId": "experiment_1592474530204_0001",
"logContent": [
{
"podName": "tf-mnist-json-ps-0",
"podLog": []
},
{
"podName": "tf-mnist-json-worker-0",
"podLog": []
}
]
}
],
"attributes": {}
} /cc @jiwq @tangzhankun |
@tangzhankun I've add |
@pingsutw , thanks for the update! LGTM. Does the Travis failure relate to the PR? |
it's unrelated to the PR, I've moved all testing to GitHub-action |
@pingsutw Thanks for the contribution. Committed it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Try to simplify client API that generated by swagger, we could add an abstract layer on swagger API, and let users more easily submit experiments
Also, prettify output in the notebook
Before: Jupyter example
After: Jupyter example
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-527?jql=project%20%3D%20SUBMARINE#
How should this be tested?
https://travis-ci.org/github/pingsutw/hadoop-submarine/builds/699648185
Screenshots (if appropriate)
Questions: