Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUBMARINE-557. Install notebook controller with helm chart #340

Closed
wants to merge 2 commits into from
Closed

SUBMARINE-557. Install notebook controller with helm chart #340

wants to merge 2 commits into from

Conversation

lowc1012
Copy link
Contributor

@lowc1012 lowc1012 commented Jul 4, 2020

What is this PR for?

Create a notebook-controller chart which used to deploy a notebook controller and upload the Notebook CRD.

What type of PR is it?

[Improvement]

Todos

  • - Task

What is the Jira issue?

SUBMARINE-557

How should this be tested?

Travis CI

Screenshots (if appropriate)

image1

image2

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

pingsutw
pingsutw reviewed Jul 4, 2020
View reviewed changes
Copy link
Member

@pingsutw pingsutw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lowc1012 Thanks for the contribution
Could you also help to update this doc

@lowc1012
Copy link
Contributor Author

lowc1012 commented Jul 5, 2020 •
edited

@pingsutw Thanks for your review! I updated helm docs.

JohnTing
JohnTing reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@JohnTing JohnTing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lowc1012 Thanks for the contribution

LGTM

jiwq
jiwq approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@jiwq jiwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks @lowc1012 for the contribution.

@asfgit asfgit closed this in c5b256f Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTing JohnTing JohnTing left review comments

@pingsutw pingsutw pingsutw left review comments

@jiwq jiwq jiwq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lowc1012 @jiwq @JohnTing @pingsutw