Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUBMARINE-533. Add pysubmarine ci dockerfile #343

Closed
wants to merge 4 commits into from

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Jul 8, 2020

What is this PR for?

Add pysubmarine ci docker image
The reason to add this dockerfile

  1. The main reason is to generate python API from swagger without install any dependencies (java, python, code-jen.jar..etc)
  2. Run pysubmarine testing and formatting Code inside docker
  3. We could also build submarine inside docker
  4. pysubmarine development

What type of PR is it?

[Improvement]

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/SUBMARINE-533

How should this be tested?

https://travis-ci.org/github/pingsutw/hadoop-submarine/builds/706069697

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pingsutw The content of this PR is too short, please add an explanation in the content of PR.
When do I need to use ./run-pysubmarine-ci.sh? Thanks!
Other places, LGTM

@pingsutw
Copy link
Member Author

@liuxunorg Thanks for the review.
Sorry for the confusion.
I've updated the content in pr and Jira

@xunliu
Copy link
Member

xunliu commented Jul 11, 2020

@pingsutw Thank you contribution this feature. :-)
Will merge if no more comnents.

@asfgit asfgit closed this in 5d0d7e7 Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants