This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
SUBMARINE-561. [SDK] Add PyTorch implementation of AFM model #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pingsutw
reviewed
Jul 18, 2020
There was a problem hiding this comment.
Thanks @andrewhsiehth for the contribution
Overall LGTM, some suggestions.
- Could we rename
AttentionalFMtoAFM, it's easier to use for users. - We could add deepfm and afm directories in
submarine-sdk/pysubmarine/example/pytorch/, and put the related file to the directories. After refactor, make sure to update the train_data path to../../data/tr.libsvm
Tensorflow deepfm example:
https://github.com/apache/submarine/tree/master/submarine-sdk/pysubmarine/example/tensorflow
submarine-sdk/pysubmarine/submarine/ml/pytorch/model/ctr/afm.py
Outdated
Show resolved
Hide resolved
|
+1, Thanks @andrewhsiehth |
|
@pingsutw Thanks for your suggestions and review. |
xunliu
approved these changes
Jul 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Add PyTorch implementation of Attentional Factorization Machine for CTR prediction. (AFM)
Make minor modifications to the PyTorch training flow.
Add testing for the AFM model.
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/SUBMARINE-561
How should this be tested?
python-sdk
Submarine
Screenshots (if appropriate)
Questions: